3ICE.HU

Posted: **Sun Mar 18, 2012 4:02 pm**

Due to the fact that I often see people attempting to find or create an adjustable/customizable Terrain-Kill trigger, I have decided to post mine on here. Before the Terrain-Kill system will work properly, you must set all of the variables via the "TerrainKill Configuration" trigger.

If you use this system, please credit me.

Here is the main trigger: ----- (Note: I have attached the map file which contains the TerrainKill Configuration trigger as well as the main trigger showed below.)

 EqualiseR's Customizable Terrain Kill System
  Events
  Time - Every 0.05 seconds of game time
  Conditions
  Actions
         For each (Integer A) from 1 to 11, do (Actions)
                Loop - Actions
           Set HeroPosition[1] = ((Position of TerrainKill_Unit[(Integer A)]) offset by TerrainKill_Severity towards 90.00 degrees)
           Set HeroPosition[2] = ((Position of TerrainKill_Unit[(Integer A)]) offset by TerrainKill_Severity towards 180.00 degrees)
           Set HeroPosition[3] = ((Position of TerrainKill_Unit[(Integer A)]) offset by TerrainKill_Severity towards 270.00 degrees)
           Set HeroPosition[4] = ((Position of TerrainKill_Unit[(Integer A)]) offset by TerrainKill_Severity towards 360.00 degrees)
           Set HeroPosition[5] = (Position of TerrainKill_Unit[(Integer A)])
           If (All Conditions are True) then do (Then Actions) else do (Else Actions)
       If - Conditions
        (Terrain type at HeroPosition[5]) Equal to Northrend - Snow
       Then - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
               If - Conditions
                (Terrain type at HeroPosition[1]) Equal to Northrend - Snow
                (Terrain type at HeroPosition[2]) Equal to Northrend - Snow
                (Terrain type at HeroPosition[3]) Equal to Northrend - Snow
                (Terrain type at HeroPosition[4]) Equal to Northrend - Snow
               Then - Actions
                Unit - Kill TerrainKill_Unit[(Integer A)]
               Else - Actions
       Else - Actions
     Wait 0.01 seconds
     Custom script:  call RemoveLocation(udg_HeroPosition[1])
     Custom script:  call RemoveLocation(udg_HeroPosition[2])
     Custom script:  call RemoveLocation(udg_HeroPosition[3])
     Custom script:  call RemoveLocation(udg_HeroPosition[4])
     Custom script:  call RemoveLocation(udg_HeroPosition[5])

~EqualiseR

Posted: **Fri Jun 01, 2012 6:00 pm**

The Wait action needs to be removed.

http://i268.photobucket.com/albums/jj2/ ... /leaks.jpg

Just a simple test with debug messages will tell you that it can't keep up with the timer.

Wait actions are usually inaccurate and have trouble executing quickly with low numbers. As a general rule, .12-.26 is where it has trouble executing quickly (I don't think it can even function below .12 seconds). Waits also cause net traffic which can cause lag if you have enough of them being used at the same time (it can also depend on the host, as far as my experience with it goes anyway). You'll mostly find trouble with this on multiplayer.

Edit: There's also no reason to have any wait-time between creating and destroying the locations.

Posted: **Sat Jun 02, 2012 7:46 pm**

Good job spotting that! Indeed, waits are not good at millisecond precision. I avoid everything below 0.27. If I need a precise short wait I use a timer. This trigger however, doesn't need any waits.

The concept is right. The execution is poor. (Because it's in GUI, and I generally don't expect anything great to come from GUI.)

Posted: **Mon Aug 27, 2012 6:14 pm**

The reason there is a wait action implemented in this trigger is because without it there seems to be excessive leaks, and in an effort to try to prevent those leaks, I added the wait action which seemed to do the job, so I saw no reason to remove it.

Posted: **Mon Aug 27, 2012 6:27 pm**

EqualiseR wrote:there seems to be excessive leaks, and in an effort to try to prevent those leaks, I added the wait action which seemed to do the job

That just makes me cringe. Excessive leaks are not fixed by adding waits, they are just hidden. You give the computer time so it can occupy more and more memory without slowing down... Until it runs out.

Without the wait the leaks were apparent. With the wait leaking still happens, but the problem is out of sight, out of mind.

I wish more people did what I do; Play your maps on a low end computer that barely meets the system requirements. Experience what it feels like to play your map in a cheap internet café in a poor third world country.

That's why we care about memory leaks. Accessibility.
Leaks crash the game. Our game doesn't crash because we have orders of magnitude more ram than required. Low end PCs don't.

Posted: **Mon Aug 27, 2012 6:58 pm**

You're not removing all of the leaks. At a second glance, I have found that you leak 4 additional locations (Position of TerrainKill_Unit[(Integer A)] 4 times in each polar projection function). Set HeroPosition[5] before your polar projection functions and use it instead of Position of TerrainKill_Unit[(Integer A)].

3ICE.HU

EqualiseR's Customizable Region/Terrain-Kill System v3.0

EqualiseR's Customizable Region/Terrain-Kill System v3.0

Re: EqualiseR's Customizable Terrain-Kill System v3.0

Re: EqualiseR's Customizable Terrain-Kill System v3.0

Re: EqualiseR's Customizable Terrain-Kill System v3.0

Re: EqualiseR's Customizable Terrain-Kill System v3.0

Re: EqualiseR's Customizable Terrain-Kill System v3.0